Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

platform option is missing #248

Open
SeanTAllen opened this issue Feb 22, 2023 · 1 comment
Open

platform option is missing #248

SeanTAllen opened this issue Feb 22, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@SeanTAllen
Copy link
Member

Once upon a time, we had a --platform option to set the platform to install for. At some point, it was mostly removed except in Main where we attempt to look at the option (which isn't in the spec so can't be set) and otherwise we check the .platform file to determine the platform OR exit.

So, at the moment you have to have a .platform file. This might not be the right thing to do, but we need to look at how all this would come together if we add --platform back in.

@SeanTAllen SeanTAllen added needs discussion Needs to be discussed further needs investigation This needs to be looked into before its "ready for work" labels Feb 22, 2023
@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Feb 22, 2023
@SeanTAllen SeanTAllen added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers and removed needs discussion Needs to be discussed further needs investigation This needs to be looked into before its "ready for work" discuss during sync Should be discussed during an upcoming sync enhancement New feature or request labels Mar 7, 2023
@SeanTAllen
Copy link
Member Author

We discussed during sync and decided that we can't come up with a use case that makes --platform valuable so the currently "useless" code should be removed and .platform should be used instead.

if .platform is missing then default command could be used.

there's no bug here, it's "just" some cleanup".

@SeanTAllen SeanTAllen added the enhancement New feature or request label Mar 7, 2023
@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Mar 7, 2023
@SeanTAllen SeanTAllen removed the discuss during sync Should be discussed during an upcoming sync label Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants