Svd2rust regress fixes #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emilgardis
previously requested changes
Jan 13, 2025
|
I added another small tweak to fix a clippy warning about lifetime ellision: e5594ba |
|
remove e5594ba and I then think we can merge this |
|
You mean moving it to another PR, or squashing everything? |
burrbull
reviewed
Jan 15, 2025
ci/svd2rust-regress/src/diff.rs
Outdated
Comment on lines
260
to
261
| fn get_source_and_command<'s>(&'s self) -> [Option<(Source<'s>, Command<'s>)>; 2] { | ||
| let split = |s: &'s str| -> (Source, Command) { |
There was a problem hiding this comment.
of use function instead of closure
Suggested change
| fn get_source_and_command<'s>(&'s self) -> [Option<(Source<'s>, Command<'s>)>; 2] { | |
| let split = |s: &'s str| -> (Source, Command) { | |
| fn get_source_and_command(&self) -> [Option<(Source, Command)>; 2] { | |
| fn split(s: &str) -> (Source, Command) { |
|
should I update the changelog as well for CI? |
Yes, please. And squash commits. |
robamu
force-pushed
the
svd2rust-regress-fixes
branch
from
882021b to
27ef196
Compare
robamu
force-pushed
the
svd2rust-regress-fixes
branch
from
27ef196 to
f08aadf
Compare
|
done |
burrbull
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used this to test a fix for #895
I fixed a lot of failing tests, however some of them are still failing. I can open an issue for that.