Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Fedex::RateError exception to a more suitable exception class #2

Open
calvinhughes opened this issue Jul 19, 2019 · 0 comments
Open

Rename Fedex::RateError exception to a more suitable exception class #2

calvinhughes opened this issue Jul 19, 2019 · 0 comments
Milestone
Refactoring plan

Comments

@calvinhughes
Copy link
Collaborator

The class Fedex::RateError is being used across all requests, despite them having no relevance whatsoever to rates.

Need to evaluate the different requests and either:

  • Use an exception related to that request
  • Rename it to be something like Fedex::RequestError
@calvinhughes calvinhughes added this to the Refactoring milestone Jul 19, 2019
@calvinhughes calvinhughes added help wanted Extra attention is needed and removed help wanted Extra attention is needed labels Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Refactoring plan
Development

No branches or pull requests
1 participant
@calvinhughes