Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify "fire a blank event" for "capturedzoomlevelchange" #50

Closed
tidoust opened this issue Dec 4, 2024 · 1 comment · Fixed by #57
Closed

Clarify "fire a blank event" for "capturedzoomlevelchange" #50

tidoust opened this issue Dec 4, 2024 · 1 comment · Fixed by #57

Comments

@tidoust
Copy link
Member

tidoust commented Dec 4, 2024

The spec current defines the oncapturedzoomlevelchange event handler as: "The user agent MUST fire a blank event on this EventHandler ...", but:

  • What is a "blank event"? In particular, what interface does the event use? Event? That should be specified, at least implicitly by linking back to "fire an event".
  • An event does not fire on an event handler. It fires at a target (an instance of some interface). Here, that would be the underlying CaptureController instance.

Ideally, the spec would rather say something like:

Given a {{CaptureController}} |controller|, the user agent MUST [=fire an event=]
named `capturedzoomlevelchange` at |controller| whenever the
|controller|.<a data-cite="!screen-capture/#dfn-source">[[\Source]]</a>'s
[=zoom level=] changes.

... and the event handler would rather be defined as:

An [=event handler IDL attribute=] whose [=event handler event type=] is
`capturedzoomlevelchange`.
@eladalon1983
Copy link
Member

Happy to affect these changes after the holidays. Thanks for suggesting them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants