Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search results are not recalculated when the filter is changed. #168

Open
davemarco opened this issue Jan 10, 2025 · 1 comment
Open

Search results are not recalculated when the filter is changed. #168

davemarco opened this issue Jan 10, 2025 · 1 comment
Assignees
@junhaoliao @Henry8192
Labels
bug Something isn't working

Comments

@davemarco
Copy link
Contributor

davemarco commented Jan 10, 2025 •
edited
Loading

Bug

If you change the log level filter, the search results do not refresh and are based on the old filter. Clicking these results may go to the wrong log event, since the log may have been filtered out

yscope-log-viewer version

f74bacf

Environment

Mac

Reproduction steps

Filter any file file, and do search. Then change the filter, and see the results are the same.
@davemarco davemarco added the bug Something isn't working label Jan 10, 2025
@davemarco
Copy link
Contributor Author

davemarco commented Jan 10, 2025 •
edited
Loading

Note the bug is also present when the file is changed. The results are not refreshed or cleared

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@junhaoliao junhaoliao

@Henry8192 Henry8192

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@junhaoliao @Henry8192 @davemarco