await mdlib.render

[boehs]

Hi Zach, I'm over here again with my incredibly-overengineered-11ty-fuzzing-how-tf-does-this-monstrosity-work-website-called-boehs.org, and this is a tiny patch.

Markdown-it does not support async, but you can implement your own markdown renderer by { render: (fileContents,data) => string }, and you may wish for this renderer to be asynchronous because you commit coding horrors

Javascript spec says

[rv] = await expression;
expression: A Promise or any value to wait for.
rv: Returns the fulfilled value of the promise, or the value itself if it's not a Promise.

so you can kinda just chuck an await on there and pray for the best. A good way to make #2827 a problem for an another day!

[zachleat]

HMM! If the function there is already async isn't it returning a promise or no? Shouldn't this already work?

[Ryuno-Ki]

You can directly return the mdlib.render call here.

Yes, it is always returning a Promise.
Using an additional async here should add another entry to the microtask queue.

(I was expecting to find a link on What Color is Your Function here 😅 )

[boehs]

HMM! If the function there is already async isn't it returning a promise or no? Shouldn't this already work?

i'm so silly

[zachleat]

@boehs don't you dare! Everyone makes mistakes (especially me) and that's what code review is for! Keep those PRs coming!