Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle missing profile when the logged in client in not a user (e.g. service owner) #2889

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

martinothamar
Copy link
Contributor

@martinothamar martinothamar commented Jan 9, 2025

Description

Handles missing profile without breaking the UI. Required to be able to process/next an instance in the context of a service owner token when the current step is datautfylling

Related Issue(s)

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

@martinothamar martinothamar changed the title Bug/org token Handle missing profile when the logged in client in not a user (e.g. service owner) Jan 9, 2025
@martinothamar martinothamar added the kind/other Pull requests containing chores/repo structure/other changes label Jan 9, 2025
@olemartinorg
Copy link
Contributor

@martinothamar Sorry! I think the failing tests might have been my fault (I made some changes in ttd/frontend-test for #2884). Rolling back now, so you can retry the tests in a minute.

@martinothamar
Copy link
Contributor Author

Just retested this locally since it's been a while. Cypress run has taken a while, not sure if something is still wrong..

Copy link
Contributor

@olemartinorg olemartinorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! 🚀

@martinothamar martinothamar merged commit eb21f32 into main Jan 13, 2025
14 of 15 checks passed
@martinothamar martinothamar deleted the bug/org-token branch January 13, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/other Pull requests containing chores/repo structure/other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants