Feature/signing cta #2890

cammiida · 2025-01-09T09:33:23Z

Description

Kan til fordel leses commit for commit 😊
Visning av feil i signeringssteget (den røde versjonen) kommer i en annen PR.

Kan testes ut ved å enten

prøve ut signering-brukerstyrt-appen i TT02: https://ttd.apps.tt02.altinn.no/ttd/signering-brukerstyrt/
Testbrukere er da Tenor testbrukere som vanlig.
eller kjøre opp signering-brukerstyrt-appen lokalt med denne frontenden og app-lib-dotnet fra branchen feature/signing.
Testbrukere finner man da i app-localtest i mappa testdata/Register/Party. Merk at det ikke er alle personer eller org som funker, men Pengelens Partner, Gjentakende Forelder og Skog og Fjell Consulting funker i hvert fall.

Siden mye fortsatt er litt usikkert, lager jeg tester senere.

Figma

Related Issue(s)

closes Signature Call-To-Action (CTA) #2641

Verification/QA

Manual functionality testing
- I have tested these changes manually
- Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
- No testing done/necessary
Automated tests
- Unit test(s) have been added/updated
- Cypress E2E test(s) have been added/updated
- No automatic tests are needed here (no functional changes/additions)
- I want someone to help me make some tests
UU/WCAG (follow these guidelines until we have our own)
- I have tested with a screen reader/keyboard navigation/automated wcag validator
- No testing done/necessary (no DOM/visual changes)
- I want someone to help me perform accessibility testing
User documentation @ altinn-studio-docs
- Has been added/updated
- No functionality has been changed/added, so no documentation is needed
- I will do that later/have created an issue
Support in Altinn Studio
- Issue(s) created for support in Studio
- This change/feature does not require any changes to Altinn Studio
Sprint board
- The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
- I don't have permissions to do that, please help me out
Labels
- I have added a kind/* label to this PR for proper release notes grouping
- I don't have permissions to add labels, please help me out

cammiida · 2025-01-15T09:22:51Z

/publish

github-actions · 2025-01-15T09:29:16Z

Published PR packages:

<link rel="stylesheet" type="text/css" href="https://altinncdn.no/toolkits/altinn-app-frontend/4.15.0.signing-cta.73448e1b/altinn-app-frontend.css">
<script src="https://altinncdn.no/toolkits/altinn-app-frontend/4.15.0.signing-cta.73448e1b/altinn-app-frontend.js"></script>

…l wrappers to app-components

… to signing panel

…t signing process modal

cammiida · 2025-01-15T12:35:11Z

/publish

github-actions · 2025-01-15T12:46:34Z

Published PR packages:

<link rel="stylesheet" type="text/css" href="https://altinncdn.no/toolkits/altinn-app-frontend/4.15.0.signing-cta.a1e94fc5/altinn-app-frontend.css">
<script src="https://altinncdn.no/toolkits/altinn-app-frontend/4.15.0.signing-cta.a1e94fc5/altinn-app-frontend.js"></script>

renames SigningPanel -> PanelSigning, NoActionRequiredPanel -> PanelNoActionRequired and AwaitingCurrentUserSignaturePanel -> PanelAwaitingCurrentUserSignature

…el with corresponding text resource changes

cammiida · 2025-01-15T17:10:01Z

/publish

github-actions · 2025-01-15T17:17:06Z

Published PR packages:

<link rel="stylesheet" type="text/css" href="https://altinncdn.no/toolkits/altinn-app-frontend/4.15.0.signing-cta.8829f31f/altinn-app-frontend.css">
<script src="https://altinncdn.no/toolkits/altinn-app-frontend/4.15.0.signing-cta.8829f31f/altinn-app-frontend.js"></script>

cammiida · 2025-01-16T08:15:38Z

/publish

github-actions · 2025-01-16T08:25:12Z

Published PR packages:

<link rel="stylesheet" type="text/css" href="https://altinncdn.no/toolkits/altinn-app-frontend/4.15.0.signing-cta.719aafea/altinn-app-frontend.css">
<script src="https://altinncdn.no/toolkits/altinn-app-frontend/4.15.0.signing-cta.719aafea/altinn-app-frontend.js"></script>

olemartinorg

Good stuff!! 💪 🚀 I have quite a few comments here, and I can't really comment about the domain-specific parts about signing (I haven't followed the work in that task force closely).

src/language/texts/en.ts

src/language/texts/nb.ts

src/layout/SigneeList/api.ts

src/layout/SigningStatusPanel/PanelAwaitingCurrentUserSignature.tsx

src/layout/SigningStatusPanel/PanelSigning.tsx

src/layout/SigningStatusPanel/SigningStatusPanel.module.css

src/layout/SigningStatusPanel/config.ts

src/layout/SigneeList/SigneeListComponent.tsx

src/layout/SigningStatusPanel/SigningStatusPanelComponent.tsx

HauklandJ

🙌

HauklandJ · 2025-01-17T08:43:30Z

src/layout/SigningStatusPanel/SigningStatusPanelComponent.tsx

+    );
+  }
+
+  if (currentUserStatus === 'awaitingSignature') {


The logic looks correct here.
We should have tests for all the cases:
User without write access, not in signeeList -> NoActionRequiredPanel
User without write access, in signeeList, has not yet signed -> AwaitingCurrentUserSignaturePanel
User without write access, in signeeList, has signed -> NoActionRequiredPanel
User with write access, not in signeeList, required have not signed -> AwaitingOtherSignaturesPanel
User with write access, not in signeeList, required have signed -> SubmitPanel
User with write access, in signeeList, has not yet signed -> AwaitingCurrentUserSignaturePanel
User with write access, in signeeList, has signed, but other required have not -> AwaitingOtherSignaturesPanel
User with write access, in signeeList, has signed, and all other required have too -> SubmitPanel

sonarqubecloud · 2025-01-20T14:22:50Z

Quality Gate failed

Failed conditions
31.4% Coverage on New Code (required ≥ 45%)
11.16% Condition Coverage on New Code (required ≥ 45%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

cammiida marked this pull request as draft January 9, 2025 09:33

cammiida added the kind/feature-request New feature or request label Jan 9, 2025

cammiida self-assigned this Jan 9, 2025

cammiida force-pushed the feature/signing-cta branch from 3687cce to ac98a99 Compare January 14, 2025 14:33

cammiida added kind/product-feature Pull requests containing new features and removed kind/feature-request New feature or request labels Jan 14, 2025

cammiida added 18 commits January 15, 2025 12:41

Signing panel scaffolding

17eb90c

fixes tests

7abe0f5

updates eslint rules for test files

031b47d

fixes function name casing

2234c76

makes panel full width by default and moves full width and conditiona…

340194a

…l wrappers to app-components

implements functions and cleans up code

f6275e7

removes reject button in mvp

52ecdcb

renames waiting status in current user status

9f39fe4

replaces signee list staleTime with refetchInterval and added padding…

c800a8e

… to signing panel

adds deprecated warning to getDataValidationUrl

636ed54

uses css classes instead of inline css

f8f3fa8

adds text resource defaults

742bf48

fixes spacing in panel and alignment of checkbox and label

7e838c2

adds checkbox label and description config to layout component

5af4e37

fixes signing document list component test

9f64a4c

adds all text resources as props for override capability

3ccee67

renames go_to_inbox -> no_action_required

db8756a

adds reject button to panel if user has reject rights

24f6e50

cammiida force-pushed the feature/signing-cta branch from 452a170 to 24f6e50 Compare January 15, 2025 11:44

cammiida added 2 commits January 15, 2025 13:20

adds text resource binding props and text resource defaults for rejec…

447ada6

…t signing process modal

ignore layout config.ts files for sonarcloud

a1e94fc

cammiida added 3 commits January 15, 2025 14:49

renames SubmitPanel -> PanelSubmit

b4d5325

renames SigningPanel -> PanelSigning, NoActionRequiredPanel -> PanelNoActionRequired and AwaitingCurrentUserSignaturePanel -> PanelAwaitingCurrentUserSignature

splits submit panel in awaiting other signatures panel and submit pan…

a19b9e7

…el with corresponding text resource changes

returns no action required panel

8829f31

cammiida marked this pull request as ready for review January 15, 2025 17:24

cammiida linked an issue Jan 16, 2025 that may be closed by this pull request

Signature Call-To-Action (CTA) #2641

Closed

fixes inverted logic error

719aafe

olemartinorg approved these changes Jan 16, 2025

View reviewed changes

HauklandJ approved these changes Jan 17, 2025

View reviewed changes

cammiida added 5 commits January 17, 2025 16:53

QA fixes

dbf5d99

Merge branch 'feature/signing' into feature/signing-cta

8ebd32a

removes redundant tests

c64fd97

Merge branch 'feature/signing' into feature/signing-cta

43e68c8

fixes document list test

49909d3

cammiida merged commit f88a0ba into feature/signing Jan 20, 2025
14 of 15 checks passed

cammiida deleted the feature/signing-cta branch January 20, 2025 14:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/signing cta #2890

Feature/signing cta #2890

cammiida commented Jan 9, 2025 •

edited

Loading

cammiida commented Jan 15, 2025

github-actions bot commented Jan 15, 2025

cammiida commented Jan 15, 2025

github-actions bot commented Jan 15, 2025

cammiida commented Jan 15, 2025

github-actions bot commented Jan 15, 2025

cammiida commented Jan 16, 2025

github-actions bot commented Jan 16, 2025

olemartinorg left a comment

HauklandJ left a comment

HauklandJ Jan 17, 2025 •

edited

Loading

sonarqubecloud bot commented Jan 20, 2025

Feature/signing cta #2890

Feature/signing cta #2890

Conversation

cammiida commented Jan 9, 2025 • edited Loading

Description

Related Issue(s)

Verification/QA

cammiida commented Jan 15, 2025

github-actions bot commented Jan 15, 2025

Published PR packages:

cammiida commented Jan 15, 2025

github-actions bot commented Jan 15, 2025

Published PR packages:

cammiida commented Jan 15, 2025

github-actions bot commented Jan 15, 2025

Published PR packages:

cammiida commented Jan 16, 2025

github-actions bot commented Jan 16, 2025

Published PR packages:

olemartinorg left a comment

Choose a reason for hiding this comment

HauklandJ left a comment

Choose a reason for hiding this comment

HauklandJ Jan 17, 2025 • edited Loading

Choose a reason for hiding this comment

sonarqubecloud bot commented Jan 20, 2025

Quality Gate failed

cammiida commented Jan 9, 2025 •

edited

Loading

HauklandJ Jan 17, 2025 •

edited

Loading