Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - Complete window dialog task when dialog is hidden #18047

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

emmauss
Copy link
Contributor

@emmauss emmauss commented Jan 24, 2025

What does the pull request do?

When a dialog window is hidden, sets the task returned with ShowDialog as complete.

What is the current behavior?

When a dialog window is shown, a task is return for user to wait on. This task is set to completed on Close, but not on Hide, even though the owner is set to null when hidden. This makes any thread waiting on the window to lock up.

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

Obsoletions / Deprecations

Fixed issues

@emmauss emmauss requested a review from grokys January 24, 2025 14:52
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.3.999-cibuild0054544-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@kekekeks
Copy link
Member

Don't we also need to update "this window has child modal dialogs" state for dialog parent?

@kekekeks
Copy link
Member

Nvm, Owner is already set to null in Hide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants