Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster-service: Fix resource file typo #912

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vkareh
Copy link

@vkareh vkareh commented Dec 1, 2024

When configuring the cloud region configuration file, a typo in the filename prevents the configuration from working correctly. Similarly, the make command not being run in silent mode appends unrelated stdout to the provision shard configuration.

@vkareh
Copy link
Author

vkareh commented Dec 1, 2024

@microsoft-github-policy-service agree company="Red Hat"

@vkareh vkareh force-pushed the cs-dev-config branch 2 times, most recently from baab910 to c8b553c Compare December 13, 2024 21:12
@vkareh vkareh changed the title cluster-service: Add CS development configuration cluster-service: Fix resource file typo Dec 13, 2024
Copy link

Please rebase pull request.

@mociarain
Copy link
Collaborator

I think this is good but you need to close this PR and move it from your fork to a branch off the main repo. Happy to help with this if I can :)

The make command not being run in silent mode appends unrelated stdout
to the provision shard configuration.
@vkareh
Copy link
Author

vkareh commented Jan 15, 2025

I think this is good but you need to close this PR and move it from your fork to a branch off the main repo. Happy to help with this if I can :)

Getting this error:

$ git push upstream 
ERROR: Permission to Azure/ARO-HCP.git denied to vkareh.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

How do I get access to pushing branches to this remote?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants