Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix boolean check in PossibleWebpBufferOverflow rule #11648

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Kisbogyi
Copy link

@Kisbogyi Kisbogyi commented Jan 9, 2025

Required items, please complete

Change(s):

  • Updated Boolean value in PossibleWebpBufferOverflow.yaml

Reason for Change(s):

  • | where DeviceId in (VulnDevices) and InitiatingProcessCommandLine has(".webp") or ProcessCommandLine has(".webp")
  • Here if ProcessCommandLine has(".webp") is true the whole line is true, because first the left, right side of and will be evalueated, and then the or.

Version Updated:

  • Yes
  • from 1.1.1 -> to 1.1.2

Testing Completed:

  • Yes

Checked that the validations are passing and have addressed any issues that are present:

  • Needs Help
  • I could not make .NET 3.1 work No usable version of libssl was found

@Kisbogyi Kisbogyi requested review from a team as code owners January 9, 2025 16:31
@v-prasadboke v-prasadboke self-assigned this Jan 10, 2025
@v-prasadboke v-prasadboke added the Solution Solution specialty review needed label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Solution Solution specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants