[AWSX] Update send-aws-services-logs-with-the-datadog-lambda-function.md #27046
+15
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaphaelAllier
approved these changes
Jan 9, 2025
Preview links (active after the
|
buraizu
requested changes
Jan 9, 2025
| resource "aws_lambda_permission" "lambda_permission" { | ||
| action = "lambda:InvokeFunction" | ||
| function_name = "datadog-forwarder" # this is the default but may be different in your case | ||
| principal = "logs.amazonaws.com" # or logs.amazonaws.com.cn for china |
There was a problem hiding this comment.
Suggested change
| principal = "logs.amazonaws.com" # or logs.amazonaws.com.cn for china | |
| principal = "logs.amazonaws.com" # or logs.amazonaws.com.cn for China* |
There was a problem hiding this comment.
In addition to the edit above, we should include the following disclaimer when mentioning the use of the AWS China regions:
*All use of Datadog Services in (or in connection with environments within) mainland China is subject to the disclaimer published in the [Restricted Service Locations](https://www.datadoghq.com/legal/restricted-service-locations/) section on our website.
Example here. It looks like putting the disclaimer after the code block, but before the end of the tab would be a good location for it. I'm not able to add a suggestion there though. Let me know if you have any questions.
buraizu
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? What is the motivation?
Merge instructions
Merge readiness:
Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the
<yourname>/descriptionnaming convention) and then add the following PR comment:Additional notes