Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add domain info to MOAB meshes and make h5m DEBUG file names consistent #6941

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

rljacob
Copy link
Member

@rljacob rljacob commented Jan 24, 2025

Make sure lat, lon, area and mask tags are all defined and have values in the component MOAB meshes
on both the component and coupler sides.

As part of confirming the above, MOABDEBUG writes of h5m files were modified so they occur at the end
of each init phase. Also changed names of some to follow a consistent naming scheme. All coupler-side
meshes start with "RecMesh". All export and import states have "export" or "import" in the title.

[BFB]

Add print of seq_flds_dom_fields to log output
Change some of the names of h5m files output as part of MOABDEBUG.
Make sure all the ones from export routines contain model_export
and the ones from import routines contain model_import.
Fix h5m file output in export with MOABDEBUG to include "atm_export"
in name.  Also move a MOAB block to more logical place in atm_init.
Add some comments.
Move MOABDEBUG write of mesh to end of lnd_init routine
Add ocn_domain_moab and call it to fill in lat, lon , mask
and other variables in MOAB mesh.

Also move some moab calls into the main HAVE_MOAB block
Add ice_domain_moab and call it to make sure
lat,lon, area, mask and frac are all defined on component side
in MOAB
Add setting of lat, lon tags for MOAB.  Also move the DEBUG
write of WholeRof to end of init routine.
Make sure lat, lon, area, mask and frac are all defined
for the coupler copies of the meshes.  Required adding
component_exch_moab calls for atm, lnd, river.

Also move the DEBUGMOAB write of the mesh to the end of each
models init section.

Also add some comments
@rljacob rljacob requested a review from iulian787 January 24, 2025 19:48
@rljacob rljacob self-assigned this Jan 24, 2025
@rljacob rljacob requested a review from vijaysm January 24, 2025 19:48
@rljacob rljacob changed the title Add domain info to MOAB meshes and make h5m DEBUG files names consistent Add domain info to MOAB meshes and make h5m DEBUG file names consistent Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant