openPMD: add software name version #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @ax3l for review. |
ax3l
reviewed
Jun 12, 2023
CMakeLists.txt
Outdated
Comment on lines
6
to
12
| # generate compile_commands.json | ||
| set(CMAKE_EXPORT_COMPILE_COMMANDS ON) | ||
| # and place it in the source directory https://stackoverflow.com/a/60910583 | ||
| add_custom_target( | ||
| copy-compile-commands ALL | ||
| ${CMAKE_COMMAND} -E copy_if_different | ||
| ${CMAKE_BINARY_DIR}/compile_commands.json ${CMAKE_CURRENT_LIST_DIR}) |
There was a problem hiding this comment.
Why do you need the compile_commands.json?
Does your IDE not support CMake directly?
There was a problem hiding this comment.
compile_commands.json is used by the C++ LSP (clangd) to parse the source files. Other build systems such as meson/bazel/etc can also generate it, so it not really CMake specific.
There are tools like Bear that can generate compile_commands.json, but generating it alongside the build reduces the number of tools needed.
modified: src/particles/elements/diagnostics/openPMD.cpp
s-sajid-ali
force-pushed
the
sajid/openpmd_software_name_version
branch
from
aa8f87b to
12677f2
Compare
Done: #381 |
ax3l
reviewed
Jun 16, 2023
ax3l
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add software name and version as attributes to openPMD outputs.