Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard File Importing #785

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

proy30
Copy link
Contributor

@proy30 proy30 commented Jan 7, 2025

This PR allows users to upload .py simulation files and have the dashboard auto-populate inputs based on sim file info. The parser currently expects input files to be structured in the same structure as the dashboard export files.

Current limitations:
- prob_relative cannot yet be parsed correctly without it's functionality modified to preserve values when max_level is modified.

  • lattice element configurations in impactx examples are built in a variety of ways (ie. referencing variables for different parameters, loading in madx file, utilizing combination of sim.lattice.extend and sim.lattice.append). The initial parser is limited - can only correctly all extract elements if the input file is structured similar to the export file.
    • Fix will come in follow-up PR

Merge after #780

Takes care of #668

@proy30 proy30 added the component: dashboard our browser based trame dashboard label Jan 7, 2025
@proy30 proy30 self-assigned this Jan 7, 2025
@proy30 proy30 changed the title [Draft] File Importing for dashboard [Draft] File Importing Jan 7, 2025
@proy30 proy30 marked this pull request as draft January 8, 2025 07:21
@ax3l ax3l changed the title [Draft] File Importing [Draft] Dashboard File Importing Jan 13, 2025
Was not properly displaying the correct information when both space charge and csr were selected
@proy30 proy30 force-pushed the dashboard/file_import branch from 35a9900 to db39d7c Compare January 23, 2025 19:32
@proy30 proy30 changed the title [Draft] Dashboard File Importing Dashboard File Importing Jan 23, 2025
@proy30 proy30 requested review from ax3l, cemitch99 and EZoni January 23, 2025 19:39
@proy30 proy30 marked this pull request as ready for review January 26, 2025 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard our browser based trame dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant