Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profiler: Charge Deposition #812

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Jan 25, 2025

Add missing annotations for the tiny profiler sections in space charge kicks: charge deposition was not captured.

Add missing annotations for the tiny profiler sections in
space charge kicks: charge deposition was not captured.
@ax3l ax3l added the component: space charge Space charge & potential solver label Jan 25, 2025
@ax3l ax3l requested review from RemiLehe and cemitch99 January 25, 2025 00:25
@ax3l
Copy link
Member Author

ax3l commented Jan 25, 2025

Hm, maybe I did not add it because ablastr::particles::deposit_charge::ChargeDeposition should have covered it anyway...

@ax3l
Copy link
Member Author

ax3l commented Jan 25, 2025

@cemitch99 , we could look at your 1B particle example again to see what we might have missed. I cannot spot directly another section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: space charge Space charge & potential solver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant