Sendonion: add total amount #8015
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lagrang3
force-pushed
the
sendonion-total-amount
branch
from
a2dd7ac to
7be5a67
Compare
Changelog-Added: sendonion: a new paramter total_amount_msat to make MPP payments with sendpay and sendonion compatible. Signed-off-by: Lagrang3 <[email protected]>
This commit can be squashed with the previous commit after PR review. Changelog-None Signed-off-by: Lagrang3 <[email protected]>
Lagrang3
force-pushed
the
sendonion-total-amount
branch
from
7be5a67 to
7593735
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to use
sendonioninrenepayinstead ofsendpayI noticed that these two rpc's are not compatiblewith each other in multi-part payments, ie. if I send a partial payment with
sendpayand try to completethe payment by sending another part with
sendonionI get an error because in the internal walletsendpaysets thetotal_amountas specified by the user whilesendoniondoes not making this amount to 0.Lightningd will only accept further payment parts if the total amounts match. With
sendonionthereisn't a field to pass the total amount so we cannot proceed.
With this PR I have added a parameter to
sendonioncalledtotal_amount_msatin order to make thesendpayandsendonioninterfaces compatible.