Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android project #178

Closed
wants to merge 3 commits into from
Closed

Android project #178

wants to merge 3 commits into from

Conversation

Velaron
Copy link
Member

@Velaron Velaron commented Jun 17, 2021 •
edited
Loading

Probably requires more features, needs feedback.

@Velaron Velaron marked this pull request as draft June 17, 2021 11:06
nekonomicon
nekonomicon reviewed Jun 17, 2021
View reviewed changes
cl_dll/cl_util.h Outdated
@@ -108,7 +108,8 @@ inline int TextMessageDrawChar( int x, int y, int number, int r, int g, int b )
inline int DrawConsoleString( int x, int y, const char *string )
{
if( hud_textmode->value == 1 )
return gHUD.DrawHudString( x, y, 9999, (char*)string, 255 * g_hud_text_color[0], 255 * g_hud_text_color[1], 255 * g_hud_text_color[2] );
return gHUD.DrawHudString( x, y, 9999, (char*)string, (int)( (float)g_hud_text_color[0] * 255.0f ),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be more clean to send separate PR.

@nekonomicon
Copy link
Member

Sorry, but I'm against gradle here.
There no reason to add yet another build system.
See discussion:
#105

Also, I'm not sure if it would be clean to have android project here.
I just think it may be bad idea to upload 20+ apks to releases in this repository.
May be It would be better to attach mod-sample as submodule here specially for modders?

@Velaron Velaron force-pushed the android branch 2 times, most recently from 0b45d2e to caa1c53 Compare June 17, 2021 22:30
@a1batross
Copy link
Member

a1batross commented Jun 17, 2021 •
edited
Loading

@nekonomicon
I see no problem in gradle and even having Android project lying just there. I wanted to do this years ago.

What about gradle? Well...

  • Android Studio natively supports it (although it's the only buildsystem supported by Android Studio).
  • Most Android devs find it convenient and there is a lot of tutorials on how to build software with Android Studio already.
  • It's possible to set it up to build native code with CMake, as opposed to deprecated Android.mk.

And I'm sorry too but mod-sample stinks. Nobody needs this unreadable mess. Yes, it can be built with lowest API level 1 but for what?

Most of the third-party mod devs just took existing Android project and used that, like one from CS16Client or one of yours. Nobody worked with mod-sample as far as I know.

@Velaron Velaron closed this Jun 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nekonomicon nekonomicon nekonomicon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Velaron @nekonomicon @a1batross