Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #54: uvloop ssl protocol transport assertion #56

Closed
wants to merge 3 commits into from

Conversation

zt50tz
Copy link

@zt50tz zt50tz commented Mar 13, 2024

Add uvloop ssl protocol transport class as possible transport class.

@zt50tz
Copy link
Author

zt50tz commented Mar 13, 2024

Issue #55 also refers to this.

@pep8speaks
Copy link

pep8speaks commented Mar 13, 2024

Hello @zt50tz! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-03-13 19:39:06 UTC

@Fatal1ty
Copy link
Owner

Hey @zt50tz

I think we can simply drop assertion here. It was introduced in this commit just for typing purposes.

@Fatal1ty
Copy link
Owner

I made a fix in #58

@Fatal1ty Fatal1ty closed this Mar 17, 2024
@zt50tz
Copy link
Author

zt50tz commented Mar 17, 2024 via email

@Fatal1ty
Copy link
Owner

My thoughts were — if assertion exists we admit that variable can be instance of some wrong type (not transport). So I added this option just because i don’t know all the code perfectly.

I think duck typing is the best choice when we deal with uvloop :D Anyway, thank you for bringing my attention to this, I'm going to prepare a new release soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants