Introduce CS_INTERRUPT_CB and corresponding return values: CS_INT_*. #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The pointer to pointer to function looks odd to me. In |
ucko
force-pushed
the
ncbi-2024-12-cs_interrupt_cb
branch
from
88b8128 to
4aef5d0
Compare
|
Good points; I've reworked it as an extension to |
|
FTR, Sybase/SAP |
Define CS_INTERRUPT_CB's numeric value alongside other CS_*_CBs'; start a new 94xx range to avoid confusion with properties. (Sybase/SAP ctlib has no such callback.) Allow specification on either the connection or the context level as usual, with the help of a shim installed on demand to minimize interference with tds_select's optimization for the no-handler case. For CS_INT_*, copy TDS_INT_* and confirm their equality at compile time as with CS_NULLTERM et al. Add a test roughly modeled on dblib's timeout.c unit test, which (alone) exercises the corresponding db_setinterrupt API. Signed-off-by: Aaron M. Ucko <[email protected]>
ucko
force-pushed
the
ncbi-2024-12-cs_interrupt_cb
branch
from
4aef5d0 to
31d7044
Compare
|
I've force-pushed a new version of this patch addressing your feedback (apart from the very longstanding use of underscore prefixes in |
|
Merged. Indented test source again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define
CS_INTERRUPT_CB's numeric value alongside otherCS_*_CBs'; start a new 94xx range to preclude accidental duplication. (Sybase/SAP ctlib has no such property.) ForCS_INT_*, copyTDS_INT_*and confirm their equality at compile time as withCS_NULLTERMet al.