Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: usage of providerUrl in fuels dev command #3528

Merged
merged 19 commits into from
Jan 10, 2025
Merged

fix: usage of providerUrl in fuels dev command #3528

merged 19 commits into from
Jan 10, 2025
+538 −1,410

Conversation

nedsalk
Copy link
Contributor

@nedsalk nedsalk commented Jan 3, 2025 •
edited
Loading

Summary

The autoStartFuelCore function wasn't using the provider url returned by launchNode but was rather constructing its own url, which led to the inability to use the ephemeral port 0 because it'd construct an invalid http://127.0.0.1:0/v1/graphql url.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@nedsalk nedsalk added the bug Issue is a bug label Jan 3, 2025
@nedsalk nedsalk self-assigned this Jan 3, 2025
@vercel Vercel
Copy link

vercel bot commented Jan 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 11:31am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 11:31am
ts-docs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 11:31am

@nedsalk nedsalk marked this pull request as ready for review January 3, 2025 09:25
@nedsalk nedsalk marked this pull request as draft January 3, 2025 09:33
@nedsalk nedsalk mentioned this pull request Jan 3, 2025
Merged
4 tasks
petertonysmith94
petertonysmith94 reviewed Jan 10, 2025
View reviewed changes
.knip.json Outdated Show resolved Hide resolved
petertonysmith94
petertonysmith94 reviewed Jan 10, 2025
View reviewed changes
package.json Outdated Show resolved Hide resolved
@nedsalk nedsalk force-pushed the ns/fix/fuels-dev-ephemeral-port branch from bc5fba1 to b328090 Compare January 10, 2025 10:20
@nedsalk nedsalk enabled auto-merge (squash) January 10, 2025 10:39
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
77.03%(+0%) 70.62%(+0%) 75.14%(+0%) 77.04%(+0%)
Changed Files:

Coverage values did not change👌.

@nedsalk nedsalk merged commit f293646 into master Jan 10, 2025
24 checks passed
@nedsalk nedsalk deleted the ns/fix/fuels-dev-ephemeral-port branch January 10, 2025 12:30
@fuel-service-user fuel-service-user mentioned this pull request Jan 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petertonysmith94 petertonysmith94 petertonysmith94 approved these changes

@danielbate danielbate danielbate approved these changes

@arboleya arboleya arboleya approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10

@maschad maschad Awaiting requested review from maschad

Assignees

@nedsalk nedsalk

Labels
bug Issue is a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for fuelCorePort: 0 in fuels.config.ts
4 participants
@nedsalk @arboleya @danielbate @petertonysmith94