-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: types of tx response and the network calls involved #3568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
danielbate
changed the title
Db/chore/tx response network calls
test: variations of Jan 8, 2025
TransactionResponse
building and the network calls involved
danielbate
requested review from
digorithm,
arboleya,
Torres-ssf,
nedsalk,
petertonysmith94 and
maschad
as code owners
January 8, 2025 18:55
danielbate
changed the title
test: variations of
chore: variations of Jan 8, 2025
TransactionResponse
building and the network calls involvedTransactionResponse
building and the network calls involved
danielbate
changed the title
chore: variations of
chore: variations of Jan 8, 2025
TransactionResponse
building and the network calls involvedTransactionResponse
and the network calls involved
danielbate
changed the title
chore: variations of
chore: types of tx response and the network calls involved
Jan 8, 2025
TransactionResponse
and the network calls involved
Coverage Report:
Changed Files:
|
arboleya
approved these changes
Jan 8, 2025
nedsalk
approved these changes
Jan 9, 2025
petertonysmith94
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I'd written some tests as part of investigations into #3545 and #3559, they paint a decent picture of the calls involved with each kind of response build and would be nice to have committed to source.
Checklist