Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: types of tx response and the network calls involved #3568

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

danielbate
Copy link
Member

@danielbate danielbate commented Jan 8, 2025

Summary

I'd written some tests as part of investigations into #3545 and #3559, they paint a decent picture of the calls involved with each kind of response build and would be nice to have committed to source.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@danielbate danielbate added the chore Issue is a chore label Jan 8, 2025
@danielbate danielbate self-assigned this Jan 8, 2025
Copy link

vercel bot commented Jan 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 6:57pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 6:57pm
ts-docs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 6:57pm

@danielbate danielbate changed the title Db/chore/tx response network calls test: variations of TransactionResponse building and the network calls involved Jan 8, 2025
@danielbate danielbate marked this pull request as ready for review January 8, 2025 18:55
@danielbate danielbate changed the title test: variations of TransactionResponse building and the network calls involved chore: variations of TransactionResponse building and the network calls involved Jan 8, 2025
@danielbate danielbate changed the title chore: variations of TransactionResponse building and the network calls involved chore: variations of TransactionResponse and the network calls involved Jan 8, 2025
@danielbate danielbate changed the title chore: variations of TransactionResponse and the network calls involved chore: types of tx response and the network calls involved Jan 8, 2025
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Coverage Report:

Lines Branches Functions Statements
76.9%(-0.07%) 70.35%(-0.14%) 74.89%(-0.13%) 76.9%(-0.07%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/providers/provider.ts 68.69%
(-0.45%)
58.08%
(+0%)
70.21%
(-1.06%)
68.42%
(-0.43%)
🔴 packages/account/src/providers/generated/operations.ts 94.03%
(-0.67%)
100%
(+0%)
81.63%
(-2.04%)
94.51%
(-0.61%)
🔴 packages/account/src/providers/transaction-request/transaction-request.ts 88.57%
(+0%)
78.08%
(+1.37%)
84%
(+0%)
88.81%
(+0%)
🔴 packages/account/src/providers/transaction-response/transaction-response.ts 76.66%
(+0.26%)
64.4%
(-1.05%)
93.75%
(+0%)
76.66%
(+0.26%)
🔴 packages/account/src/providers/transaction-summary/assemble-transaction-summary.ts 100%
(+0%)
77.77%
(+6.35%)
100%
(+0%)
100%
(+0%)
🔴 packages/account/src/providers/transaction-summary/calculate-tx-fee-for-summary.ts 100%
(+0%)
90%
(-1.66%)
100%
(+0%)
100%
(+0%)
🔴 packages/account/src/providers/transaction-summary/status.ts 100%
(+0%)
93.33%
(+2.43%)
100%
(+0%)
100%
(+0%)
🔴 packages/address/src/address.ts 90.9%
(-0.17%)
86.66%
(+0%)
85.71%
(+0%)
91.07%
(-0.15%)
🔴 packages/address/src/utils.ts 69.23%
(-9.03%)
50%
(-21.42%)
77.77%
(-9.73%)
70.37%
(-8.79%)

@danielbate danielbate merged commit a5bb56f into master Jan 9, 2025
51 of 68 checks passed
@danielbate danielbate deleted the db/chore/tx-response-network-calls branch January 9, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants