Add logging information when a dataset has already been imported #4377
+13
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zedmonds96
changed the title
dafeder
requested changes
Jan 9, 2025
There was a problem hiding this comment.
@zedmonds96 can we follow the pattern for other tests on this class, to check for the logger execution as well? If you look at ImportQueueWorkerTest::testErrorPath() I think you'll see a pattern you can use in ::testProcessItemAlreadyImported().
|
@dafeder is this cypress test failure related to my changes? |
|
I'm sure it's a random failure we keep getting on that test. Can you rerun it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4334
Describe your changes
Add logging facilities to Drupal\datastore\Plugin\QueueWorker\ImportQueueWorker::processItem() such that it informs the user that the dataset already exists and will not be imported.
QA Steps
Checklist before requesting review
If any of these are left unchecked, please provide an explanation