-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Endpoint/recover #247
base: master
Are you sure you want to change the base?
Endpoint/recover #247
Conversation
@prudradeep thanks so much! I will try to put aside some time in the near future to do a thorough review of all the recent PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! I added some comments on a few issues that I saw. Let me know if anything isn't clear.
Before this can be merged, we'll need to add sufficient tests to cover this endpoint. We'll also need to make sure the documentation is up to date and explains how this feature functions.
If you are interested in doing this, here are some starting points to reference:
https://github.com/JKHeadley/rest-hapi/blob/master/tests/unit/handler-helper.tests.js
https://github.com/JKHeadley/rest-hapi/blob/master/tests/unit/rest-helper-factory.tests.js
https://github.com/JKHeadley/rest-hapi/tree/master/tests/e2e
Please let me know if this is something you are interested in doing. Otherwise I will do my best to get to it when I can.
Thanks so much!
No description provided.