[IJPL-174685] Do not continue processing if kotlin data node is null #2898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the search for the dataNode uses a name comparison, and for the case of Android for example, the names won't match and we will end up finding nothing. The function should not continue processing data if the dataNode is null because it will just use fallbacks instead of configuring the right way. For the NAdroid case, we even have our own data service that actually passes the right name in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the search for the dataNode uses a name comparison, and for the case of Android for example, the names won't match and we will end up finding nothing. The function should not continue processing data if the dataNode is null because it will just use fallbacks instead of configuring the right way. For the NAdroid case, we even have our own data service that actually passes the right name in this case.