Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash USER environment variable during system_uuid fallback #587

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nHackel
Copy link

@nHackel nHackel commented Jan 25, 2025

I recently encountered a system where the USER environment variable got set to "domain/user". Such a name then gets interpreted as a filepath which breaks the system_uuid_fallback logic.

As a workaround this PR hashes the variable before using it in the filepath creation. Same user names should still result in the same hash values

@nHackel
Copy link
Author

nHackel commented Jan 25, 2025

Ah actually the docs mention that the hash may change when a new process is started. I'm not entirely sure if that is an issue here, because the workers should be started before Dagger is loaded according to the docs. I also wasn't able to locally produce different hashes for the same value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant