Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sufix "es" #157

Closed
wants to merge 1 commit into from
Closed

Remove sufix "es" #157

wants to merge 1 commit into from

Conversation

Alerinos
Copy link

Adding a sufix to the end of each table name looks very bad. More information is described here. #153
I don't think this is a needed feature (even my client laughed about it when he asked me if I was exaggerating).
Alternatively, you can make settings

@antifree
Copy link
Member

antifree commented Dec 10, 2022

Hello!
Thank you for the contribution and sorry for answering lately. Could you please add an option for this change? I think it depends on the use-case to use plural or singular form

Copy link

@tombohub tombohub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no shortcuts

@Alerinos
Copy link
Author

Alerinos commented Feb 1, 2023

@antifree
It seems to me that it shouldn't be, if someone wants to use their own name, they will use this:

[Display(Name = "HashTags", Description = "List of tags in the article")]
public class HashTag { ... }

@Alerinos
Copy link
Author

@eqteamlead @antifree We can make such a simple change and let the programmer decide how we want to name the model?

Copy link
Collaborator

@korzh korzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We won't apply this change. The name of the property says exactly what it means (NamePlural). If you need the original entity name there is just the Name property for that.

@korzh
Copy link
Collaborator

korzh commented Feb 3, 2024

We don't accept this change. If you need to show the original (not plural) names for each entity - there is usePluralNames property of EasyDataViewDispatcher and RootDataView. So, you can simply set that option to false:

new EasyDataViewDispatcher({
    endpoint: '/api/easydata',
    usePluralNames: false
}).run();

@korzh korzh closed this Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants