Allow sending report only to admins (fixes #2414) #5350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nutomic
force-pushed
the
report-to-admins
branch
from
b842e95 to
a01c5ab
Compare
Nutomic
commented
Jan 24, 2025
| // which have `to_local_admins == false`. | ||
| query = query | ||
| .filter(filter_is_mod) | ||
| .filter(filter_to_local_admins.is_distinct_from(true)); |
There was a problem hiding this comment.
I tried to move this into a helper function fn filter(&mut query) but they generic parameters get very confusing. Worst case we have to copy-paste this whole filter logic into get_report_count().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new parameter
to_local_adminsfor all report tables in the db, and all create report api parameters. This way most reports are only shown to community mods by default, and not to admins. It resolves the problems described in #2414 and Report Inboxes RFC with minimal changes (no new db tables or api endpoints).By default admins only see reports marked
to_local_admins(for important rule violations), and reports of communities they moderate themselves. Additionally reports which are unresolved for more than three days are shown to admins, in order to help out with unmoderated communities. There is also a parameterListReports.show_mod_reportswhich allows admins to view all reports.