Automated download #30
Open
+92
−2,680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @vweevers this is a GREAT idea and one my team was talking about. Does your implementation work? Do you mind if we fork? |
|
I haven't used local-dynamo since a short while after submitting this PR. But it worked well. There was one issue with HTTP redirects, in the So if you fork (no need to ask 👍), be sure to update the download and download-status dependencies. One more thing: another dependency, path-exists, switched from callbacks to Promises, so you either need to adapt the code, or pin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of bundling DynamoDB Local (and trusting PR's of strangers to upgrade it), I'd rather have
local-dynamodownload the code directly from Amazon. Added benefits:launch({ version: "2015-07-16_1.0" })~/.local-dynamo/[version], so it only has to download once. This keeps the package small.Though I realize this is a significant change (and breaks the API because of asynchronicity), I hope it's worth your consideration. And if not, it could also be adapted to a build script, for easy upgrades.