-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rqbit: 7.0.1 -> 8.0.0 #372777
base: master
Are you sure you want to change the base?
rqbit: 7.0.1 -> 8.0.0 #372777
Conversation
@Daru-san Only mildly related, but best place to do this i think. |
also you need to update |
I do? When i changed the version and tried to built, only the hashes i changed were not identical anymore. And since it uses the version number from the top to fetch all the things it needs, i dont see why or even to what i would need to change those hashes. |
464200f
to
4f916dd
Compare
yes you do, if you don't change the src hash, nix will download the old cached (7.0.1) version from the nix caches |
@ToasterUwU I am free to help get the desktop app working. Thankfully tauri was updated to 2.0.0 in this release, so it may work better this time. |
@Daru-san Yeah i wanted this in a seperate PR anyways. So just open one when this one gets merged and ping me to let me know. |
@@ -12,7 +12,7 @@ | |||
let | |||
pname = "rqbit"; | |||
|
|||
version = "7.0.1"; | |||
version = "8.0.0"; | |||
|
|||
src = fetchFromGitHub { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to update src.hash and npmDepsHash too.
Also the lib.optionals stdenv.hostPlatform.isDarwin [ darwin.apple_sdk.frameworks.SystemConfiguration ];
below can be removed.
You could consider adding an update script like
|
please update:
and
|
Yes im aware, just busy atm. Give me some time |
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.