-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce support for InterSystems IRIS #2416
base: master
Are you sure you want to change the base?
Changes from all commits
00f6500
dad187e
5b3d8d4
cb43436
38f24f9
2ebfdf9
cbd2cf0
70602bf
083b177
d59f4cc
6a01214
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
# Using WebAPI with InterSystems IRIS support | ||
|
||
## Building WebAPI | ||
|
||
To build WebAPI with InterSystems IRIS support, you can simply use the `webapi-iris` profile | ||
when building WebAPI with Maven: | ||
|
||
```Shell | ||
mvn -Pwebapi-postgresql,webapi-iris clean package | ||
``` | ||
|
||
or on Windows PowerShell: | ||
```Shell | ||
mvn "-Pwebapi-postgresql,webapi-iris" clean package | ||
``` | ||
|
||
This will automatically download and package a recent version of the InterSystems IRIS JDBC | ||
driver from Maven Central. | ||
|
||
Alternatively, the JDBC driver for InterSystems IRIS can be found in the `dev/java/lib/1.8/` | ||
subfolder of your IRIS installation, or as a download from InterSystems Cloud Services portal. | ||
|
||
|
||
## Sample configuration | ||
|
||
When configuring Atlas / WebAPI to access CDM on IRIS over a secure connection, your source | ||
registration looks like this: | ||
```SQL | ||
INSERT INTO webapi.source (source_id, source_name, source_key, source_connection, source_dialect, username, password) | ||
VALUES (<#>, 'OHDSI IRIS Database', 'IRIS', 'jdbc:IRIS://<hostname>.elb.us-west-2.amazonaws.com:443/USER/:::true', | ||
'iris', '<username>','<password>'); | ||
``` | ||
|
||
For a non-encrypted, local connection, this may look like: | ||
```SQL | ||
INSERT INTO webapi.source (source_id, source_name, source_key, source_connection, source_dialect, username, password) | ||
VALUES (<#>, 'OHDSI IRIS Database', 'IRIS', 'jdbc:IRIS://localhost:1972/USER/', 'iris', '_SYSTEM_','SYS'); | ||
``` | ||
|
||
|
||
## References | ||
|
||
For more information on how to connect to InterSystems IRIS or InterSystems IRIS Cloud SQL, please see: | ||
* [Connecting your applications to Cloud SQL](https://docs.intersystems.com/components/csp/docbook/DocBook.UI.Page.cls?KEY=GDRIVE_cloudsql) | ||
* [Troubleshooting connection issues](https://docs.intersystems.com/services/csp/docbook/DocBook.UI.Page.cls?KEY=ACTS) | ||
* [InterSystems fork for OHDSI Broadsea](https://github.com/isc-krakshith/InterSystems-Broadsea/) |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -82,7 +82,7 @@ public DataSource primaryDataSource() { | |
//note autocommit defaults vary across vendors. use provided @Autowired TransactionTemplate | ||
|
||
String[] supportedDrivers; | ||
supportedDrivers = new String[]{"org.postgresql.Driver", "com.microsoft.sqlserver.jdbc.SQLServerDriver", "oracle.jdbc.driver.OracleDriver", "com.amazon.redshift.jdbc.Driver", "com.cloudera.impala.jdbc.Driver", "net.starschema.clouddb.jdbc.BQDriver", "org.netezza.Driver", "com.simba.googlebigquery.jdbc42.Driver", "org.apache.hive.jdbc.HiveDriver", "com.simba.spark.jdbc.Driver", "net.snowflake.client.jdbc.SnowflakeDriver", "com.databricks.client.jdbc.Driver"}; | ||
supportedDrivers = new String[]{"org.postgresql.Driver", "com.microsoft.sqlserver.jdbc.SQLServerDriver", "oracle.jdbc.driver.OracleDriver", "com.amazon.redshift.jdbc.Driver", "com.cloudera.impala.jdbc.Driver", "net.starschema.clouddb.jdbc.BQDriver", "org.netezza.Driver", "com.simba.googlebigquery.jdbc42.Driver", "org.apache.hive.jdbc.HiveDriver", "com.simba.spark.jdbc.Driver", "net.snowflake.client.jdbc.SnowflakeDriver", "com.databricks.client.jdbc.Driver", "com.intersystems.jdbc.IRISDriver"}; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you describe how you would download the IRIS JDBC driver? A quick Google search brought me to this page: https://intersystems-community.github.io/iris-driver-distribution/. It would be useful to document this in the pull request and other OHDSI documentation. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is described in our forthcoming DatabaseConnector submission (and taken care of in the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @bdeboe - a maven profile would be ideal. To document how to use it you can follow the example for some of the other db platforms such as: https://github.com/OHDSI/WebAPI/tree/master/src/main/extras/bigquery. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done. (see last two commits on this branch) Please let me know if there's anything else you'd like us to add before this PR is eligible to be merged |
||
for (String driverName : supportedDrivers) { | ||
try { | ||
Class.forName(driverName); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noting that SqlRender v1.19.0 release notes mentioned that IRIS support is 'tentative'. By extension, we'll view IRIS support as 'tentative' in WebAPI & ATLAS.