Make control allocation and actuator effectiveness a non-module-specific library #24196
+62
−53
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
When trying to implement a separate metric control allocation module, it seems that sharing the control allocation library seems like a sensible solution.
Solution
ControlAllocation
andActuatorEffectiveness
a library that can be shared across multiple modulescontrol_allocator
module and only keep theActuatorEffectiveness
base class in the library.Changelog Entry
For release notes:
Test coverage
Context