-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow tab bar customization #83
Conversation
hi @tcorreiaubi thanks for the PR, the changes do make sense. However, expo is officially supporting only rc.0. The rc.1 and rc2 have native code changes that expo didn't follow up yet. So we need to avoid using You can keep it open and wait for official support or you can come up with a different solution (Probably interpolating the opacity as the current implementation). |
@PedroBern I was actually just looking at it, the interpolateColor behavior ended up looking really not good as expected, I guess a simple condition rendering either 1 color or another will do it for the moment, I will update the pull request |
6257047
to
40a071c
Compare
@PedroBern fixed, I'm also working in implementing a minimum collapsible header height, will make the pull request tomorrow. |
@tcorreiaubi @PedroBern I was actually working on pretty much the same PR today... In my project, I have implemented I finally solved it by using '@react-native-community/masked-view' with an animated background under the icon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good, just some minor changes
Also, not sure why the yarn.lock changes, what's the difference?
@alexpchin clever solution. |
40a071c
to
5eb7708
Compare
@PedroBern Fixed, I think it can be merged |
@tcorreiaubi nice work 👍 Need to solve some conflicts, you can copy the example you wrote in the readme and add it as a docstring to the tabbar. Will need to remove the And delete the prop table, it will be auto-generated. Then, run |
5eb7708
to
f97527c
Compare
@PedroBern Done, let me know if something is missing |
Hey, this is based mostly on the approach that react-native-tab-view takes about styling their tab bar, the idea is to allow customization without having to refactor/copy the existent bar.
I had to increase the package version because of the following error coming from interpolateColor
software-mansion/react-native-reanimated#1401
Let me know if this changes make sense
Closes #82