Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: eliminate rdflib.term.Genid and rdflib.term.RDFLibGenid #2459

Open
wants to merge 6 commits into
base: 8.x
Choose a base branch
from

Conversation

aucampia
Copy link
Member

@aucampia aucampia commented Jun 19, 2023

Summary of changes

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • If the change adds new features or changes the RDFLib public API:
    • Created an issue to discuss the change and get in-principle agreement.
    • Considered adding an example in ./examples.
  • If the change has a potential impact on users of this project:
    • Added or updated tests that fail without the change.
    • Updated relevant documentation to avoid inaccuracies.
    • Considered adding additional documentation.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

@nicholascar nicholascar requested a review from edmondchuc July 25, 2024 02:15
- update existing tests for de-skolemization
- add new test to test single skolem IRI de-skolemization works correctly
# Conflicts:
#	rdflib/graph.py
#	rdflib/term.py
@edmondchuc edmondchuc marked this pull request as ready for review July 29, 2024 05:11
@edmondchuc edmondchuc requested a review from ashleysommer July 29, 2024 05:15
@coveralls
Copy link

coveralls commented Jul 29, 2024

Coverage Status

coverage: 90.314% (+0.04%) from 90.276%
when pulling de6a8b2 on aucampia:aucampia/20230619T2345-remove_genid
into e8f61d4 on RDFLib:main.

@edmondchuc edmondchuc requested a review from nicholascar August 1, 2024 06:23
@edmondchuc edmondchuc self-assigned this Sep 29, 2024
@edmondchuc
Copy link
Contributor

Requires a follow-up from me to fix the conflicts in main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eliminate rdflib.term.Genid and rdflib.term.RDFLibGenid
4 participants