Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all functions of javaluator #2785

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Teifun2
Copy link

@Teifun2 Teifun2 commented Jan 25, 2025

Description of Changes

Please provide a summary of the changes, including:

The matcher now accepts all these functions / symbols

  • Why the change was made
    Functions like modulo, abs, floor, ceil, can be vital for reordering properly. This should now be possible.

  • Any challenges encountered
    Finding the documentation of the underlying expression / what is possible or not.


Checklist

General

Documentation

UI Changes (if applicable)

  • Screenshots or videos demonstrating the UI changes are attached (e.g., as comments or direct attachments in the PR)

Testing (if applicable)

  • I have tested my changes locally. Refer to the Testing Guide for more details.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. enhancement New feature or request labels Jan 25, 2025
@github-actions github-actions bot added the Java Pull requests that update Java code label Jan 25, 2025
@Frooodle
Copy link
Member

I cant think of a usecase why any user would want to sin(x) for a pdf page index, Can you think of examples for any of these?

@Teifun2
Copy link
Author

Teifun2 commented Jan 25, 2025

@Frooodle Yes. I was also wondering if i should include all functions or only the ones i need / can think of a need.

But in the end i decided to allow them all, as all of them to my understanding can be computed by javaluator. Why restrict something just because i cant think of a usecase.

If you would rather have the ones that are actually usefull that would be fine for me aswell. I was only looking for modulo initialy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Java Pull requests that update Java code size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants