[fix
] Simplify save_to_hub
, remove git dependency, add 'token' argument
#2376
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1777, Fixes #1760, Fixes #1925
Hello!
Pull Request overview
save_to_hub
:git-lfs
doesn't need to work.upload_folder
from legacyRepository
+ git-lfs.token
argument. Doesn't need to be provided ifhuggingface-cli login
has been done.NOTE:save_to_hub
now returns the URL to the uploaded model files, not the commit!transformers>=4.32.0
, required fortoken
as used inmain
huggingface_hub>=0.15.1
as required bytransformers>=4.32.0
Details
The huggingface_hub has updated its recommended workflow on how to upload files, and this PR follows the updated version.
NOTE:save_to_hub
now returns the URL to the uploaded model files, not the commit! I theorize that this is not a big issue, as I don't suspect many people to use the returned URL.E.g.