Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEM-442] Check bom number to change display type when upgrading #203

Merged

Conversation

Jipolie01
Copy link
Contributor

@Jipolie01 Jipolie01 commented Dec 30, 2024

Description

Instead of using a somewhat hardcoded display type, we allow for dynamically assigning the machines BOM number as the display option for upgrading

How has this been tested

The start_update script is given the correct BOM number.

Ready for Review Checklist

To help with deciding if this PR is RFR, use this checklist.

The author confirms that:

  • the author has self-reviewed this work and is highly confident about the quality
  • this work satisfies all acceptance criteria that are stated in the linked ticket
  • this work has been tested on all product families and the process and results are documented in the above section
  • The description above is concise yet complete
  • the reviewer has been offered a walkthrough (if needed)
  • the code is cleaned from any rubbish (e.g. meaningless comments, log-spamming, etc...)
  • remaining #TODO comments mention a Jira ticket number
  • all CI checks are passing
  • all commits are (re)structured to be meaningful and clearly arranged, and all are prepended with the ticket number for traceability

robinmdh
robinmdh previously approved these changes Jan 6, 2025
Copy link
Member

@robinmdh robinmdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

initramfs/init.sh Outdated Show resolved Hide resolved
@Jipolie01 Jipolie01 force-pushed the SEM-442_Change_reference_to_update_screen_imx8 branch from 0111630 to d488fae Compare January 7, 2025 16:11
@Jipolie01 Jipolie01 requested a review from alexborro January 8, 2025 13:11
@Jipolie01 Jipolie01 merged commit 98ce82c into master/imx8 Jan 9, 2025
4 checks passed
@Jipolie01 Jipolie01 deleted the SEM-442_Change_reference_to_update_screen_imx8 branch January 9, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants