Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add number of rows inside group #199

Merged
merged 8 commits into from
Dec 23, 2024
Merged

Add number of rows inside group #199

merged 8 commits into from
Dec 23, 2024

Conversation

vitPinchuk
Copy link
Contributor

Resolves: #189

@vitPinchuk vitPinchuk self-assigned this Dec 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.80%. Comparing base (7c44113) to head (e4658e1).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #199   +/-   ##
=======================================
  Coverage   99.80%   99.80%           
=======================================
  Files         189      189           
  Lines        3018     3024    +6     
  Branches      698      702    +4     
=======================================
+ Hits         3012     3018    +6     
  Misses          6        6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikhail-vl mikhail-vl added the enhancement New feature or request label Dec 13, 2024
@mikhail-vl mikhail-vl added this to the Table 2.0.0 milestone Dec 13, 2024
@vitPinchuk vitPinchuk marked this pull request as ready for review December 16, 2024 15:02
asimonok
asimonok approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl ready for review

mikhail-vl
mikhail-vl approved these changes Dec 23, 2024
View reviewed changes
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl mikhail-vl merged commit 78e7a46 into main Dec 23, 2024
7 checks passed
@mikhail-vl mikhail-vl deleted the feat/number-of-rows branch December 23, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikhail-vl mikhail-vl mikhail-vl approved these changes

@asimonok asimonok asimonok approved these changes

Assignees

@vitPinchuk vitPinchuk

Labels
enhancement New feature or request
Projects
Business Suite
Archived in project
Milestone
Table 2.0.0
Development

Successfully merging this pull request may close these issues.

Show number of rows inside group
4 participants
@vitPinchuk @codecov-commenter @asimonok @mikhail-vl