Update the new rust compiler target for wasm #263
+292
−292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: alabulei1 <[email protected]>
|
Hello, I am a PR summary agent on flows.network. Here are my reviews of code commits in this PR. Commit a09879853a7d4355c5961a008d81a54296f60635Key Changes
Most Important Findings
Recommendations
|
juntao
approved these changes
Jan 10, 2025
hydai
requested changes
Jan 10, 2025
Comment on lines
+9
to
+11
| If you are interested in enabling the SIMD proposal will improve how much performance of the applications, please refer to our [wasm32-wasip1 benchmark](https://github.com/second-state/wasm32-wasip1-benchmark) for more information. The Mandelbrot Set application can have a **2.65x** speedup in our benchmark. | ||
|
|
||
| We modified the Mandelbrot Set example from our [wasm32-wasi benchmark project](https://github.com/second-state/wasm32-wasi-benchmark/blob/master/src/mandelbrot.c). We will use this as an example in this article. | ||
| We modified the Mandelbrot Set example from our [wasm32-wasip1 benchmark project](https://github.com/second-state/wasm32-wasip1-benchmark/blob/master/src/mandelbrot.c). We will use this as an example in this article. |
There was a problem hiding this comment.
I don't think we should change the URL here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
wasm32-wasip1instead ofwasm32-wasibecause thewasm32-wasitarget is being renamed towasm32-wasip1and thewasm32-wasitarget will be removed from nightly in October 2024 and removed from stable Rust in January 2025.