Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for &gotodeviceip=x.x.x.x #6672

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

nmmclwhitehead
Copy link
Contributor

#3894

similar to this commit only with ip of device

https://meshcentral/?viewmode=10&gotodeviceip=10.1.1.1

add url option for device ip
add url parm for device ip
@si458
Copy link
Collaborator

si458 commented Jan 7, 2025

im assuming this feature is for internal meshcentral/amt?
only reason is this feature wont work for myself because i host meshcentral in the cloud
so all my node devices show the SAME IP, so when i goto an ip it will just pick the last node in the list

p.s. you also forgot to add your feature into default3.handlebars which is the new bootstrap theme ?sitestyle=3

@nmmclwhitehead
Copy link
Contributor Author

@si458 correct this is an internal server setup
havnt had much time to dig into the code yet but how is the node.ip populated from the device hardware ip or the agent ip?

thanks for the reminder ill add to that too

@si458
Copy link
Collaborator

si458 commented Jan 7, 2025

the node.ip is the connecting IP adress from the meshagent
so if a machine connects to your meshcentral internally, it would show the IP of the remote device
if a machine connects to your meshcentral over the internet, it would be the IP address of the devices external IP
if the device was AMT it would be again the intel AMT ip address
if it was CIRA it would be the machines external IP address

bottom line is its the IP address the remote device is CONNECTING FROM, its not given to meshcentral, its whatever meshcentral sees the IP address as (if that makes sense)

add url parm for device ip
@nmmclwhitehead
Copy link
Contributor Author

ah makes sense ... thanks for the explanation

i guess its not so useful for remote device or there are multiple devices at the same location

my use case is i can only pull IP address for logged in users(active directory security events) - rather than doing a DNS query for each i though this might be less overhead lol

@si458
Copy link
Collaborator

si458 commented Jan 7, 2025

no to be honest its a brilliant feature and i can see how it would be helpful to you!
but to myself and mabe others it wouldnt be very helpful
so will merge little later on if you have tested and all is working well!

@si458 si458 merged commit 1a02539 into Ylianst:master Jan 8, 2025
3 checks passed
@nmmclwhitehead nmmclwhitehead deleted the gotodeviceip branch January 8, 2025 13:47
@si458
Copy link
Collaborator

si458 commented Jan 10, 2025

1.1.38 released with this PR 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants