Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nodejs version with respecting the runs.using #983

Merged
merged 4 commits into from
Jan 10, 2025

Conversation

kachick
Copy link
Contributor

@kachick kachick commented Dec 19, 2024

Description

Now using different nodejs version with action.yml.
Is this an intentional change?

runs:
using: node20

As far as I know, GitHub Action JavaScript runner does not support nodejs 22 engine yet.

ref: #923, #940


What I did

Revert following commits

Prevent similar troubles with following changes

  • Add ignore entry for dependabot config
  • Restrict engines.node in package.json

Revert following commits

- 2e3c15b
- Part of 7c33447

Prevent similar troubles with following changes

- Add ignore entry for dependabot config
- Restrict engines.node in package.json
@kachick kachick requested a review from a team as a code owner December 19, 2024 18:03
@Osama2535
Copy link

وصف

لقد استخدمت الآن إصدارًا مختلفًا من Nodejs باستخدام action.yml. هل هذا تغييرود؟

runs:
using: node20

بقدر ماتعلم، فإن تشغيل برنامج JavaScript الخاص بـ GitHub Action لا يدعم محرك Nodejs 22 حتى الآن.

المرجع: #923 ، #940

ماذا فعلت

الفن عن الالتزامات التالية

تجنب شراء نفس باتباع التغييرات التالية

  • إضافة تجاهل تجاهل لتكوين التابع
  • تمامًا مثل Engines.node في package.json

Osama

@kachick
Copy link
Contributor Author

kachick commented Jan 10, 2025

c8ae611
8efb6d2

@ncalteen If you want to address this problem in #969, I can close this PR. Could you please share your intention?

@ncalteen
Copy link
Collaborator

Please keep this open! I would like to ensure you get contribution credit :)

@ncalteen
Copy link
Collaborator

Hey @kachick can you please take a look at the package-lock.json and possibly rebuild it? I thought I got all the merge conflicts fixed but looks like I might be off on a version.

And updated the lock file with `npm install`
@ncalteen
Copy link
Collaborator

Can you pull in the changes from main and resolve the conflicts in package.json and package-lock.json?

@kachick
Copy link
Contributor Author

kachick commented Jan 10, 2025

Thanks for letting me know, I have resolved the conflict and npm run all is okay in my local.

@ncalteen ncalteen self-assigned this Jan 10, 2025
@ncalteen
Copy link
Collaborator

Thank you very much!

@ncalteen ncalteen merged commit da77bec into actions:main Jan 10, 2025
6 checks passed
@kachick
Copy link
Contributor Author

kachick commented Jan 10, 2025

Thank you for reviewing and merging!

@kachick kachick deleted the fix-nodejs-version-20 branch January 10, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants