Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move global utils to ag-charts-core (1) #3361

Merged
merged 6 commits into from
Jan 10, 2025
Merged

Conversation

iMoses
Copy link
Contributor

@iMoses iMoses commented Jan 10, 2025

  • moved global types & type guards
  • moved new validation implementation + string utils
  • added test support for the core package
  • added myself to the core package codeowners

- moved global types & type guards
- moved new validation implementation + string utils
- added test support for the core package
@iMoses iMoses requested review from alantreadway and a team as code owners January 10, 2025 10:56
Copy link
Member

@alantreadway alantreadway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alantreadway alantreadway merged commit a1b5d6f into latest Jan 10, 2025
27 checks passed
@alantreadway alantreadway deleted the imoses/core-utils-1 branch January 10, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants