fix: k8s meta index #2032
Merged
fix: k8s meta index #2032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abingcbc
force-pushed
the
k8s_meta
branch
2 times, most recently
from
2023b06 to
d4c641e
Compare
messixukejia
requested changes
Jan 12, 2025
| @@ -10,6 +10,24 @@ import ( | |||
| "github.com/alibaba/ilogtail/pkg/logger" | |||
| ) | |||
|
|
|||
| type IndexItem struct { | |||
There was a problem hiding this comment.
1、cache是内存密集型的，需要把内存通过指标体现出来
2、指标现在是否能通过Lens承载。指标现在比较多（包括之前的http请求），需要考虑后端的承载能力，不一定都会上报上来。
Abingcbc
force-pushed
the
k8s_meta
branch
2 times, most recently
from
7791db0 to
a1836d9
Compare
Abingcbc
commented
Jan 13, 2025
| @@ -169,36 +163,14 @@ func (m *MetaManager) RegisterSendFunc(projectName, configName, resourceType str | |||
| } | |||
| } | |||
|
|
|||
| func (m *MetaManager) UnRegisterSendFunc(projectName, configName, resourceType string) { | |||
| if cache, ok := m.cacheMap[resourceType]; ok { | |||
| func (m *MetaManager) UnRegisterAllSendFunc(projectName, configName string) { | |||
There was a problem hiding this comment.
这里是优化了一下锁。因为每种资源的cache unregister很快，在Manager这里不用频繁申请锁了，直接申请一次，全部遍历一遍
messixukejia
requested changes
Jan 13, 2025
| switch pod.OwnerReferences[0].Kind { | ||
| case "ReplicaSet": | ||
| switch { | ||
| case linkType == POD_REPLICASET && pod.OwnerReferences[0].Kind == "ReplicaSet": |
linrunqi08
approved these changes
Jan 13, 2025
| event.Object.FirstObservedTime = obj.FirstObservedTime | ||
| oldIdxKeys = m.getIdxKeys(obj) |
There was a problem hiding this comment.
如果是update事件，还需要先delete再add吗？你这里怎么判断是1还是2？
There was a problem hiding this comment.
update也需要先delete再add，因为新的索引和旧的索引可能不同，例如Pod的container id
Abingcbc
force-pushed
the
k8s_meta
branch
2 times, most recently
from
61f3ec5 to
9292932
Compare
messixukejia
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
问题
由于存在多个对象index相同的情况，所以索引中的value是一个数组。但是处理update事件时没有覆盖旧的索引，导致重复发送。
修复