Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create a fillet on an edge/face #1621

Open
wants to merge 19 commits into
base: blitz
Choose a base branch
from
Open

feat: create a fillet on an edge/face #1621

wants to merge 19 commits into from
+88 −4

Conversation

jonahrb
Copy link
Contributor

@jonahrb jonahrb commented Jan 10, 2025 •
edited
Loading

Description

Add the fillet command, which provides the ability to create a fillet on an edge or adjust the existing fillet of a face.

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

jonahrb and others added 17 commits October 18, 2024 15:14
@jonahrb
implement chamfer and test
bf9dda7
@pyansys-ci-bot
chore: adding changelog file 1495.added.md [dependabot-skip]
5e2710a
@jonahrb
cleanup
6fcbec1
@jonahrb
bump api geometry
282b43c
@jonahrb
more cleanup
645c8a8
@RobPasMue
Merge branch 'main' into feat/chamfer
359cf8e
@jonahrb
final cleanup, add example
7b4c94c
@jonahrb
Merge branch 'feat/chamfer' of https://github.com/ansys/pyansys-geometry
c00e7be 
 into feat/chamfer
@jonahrb
Merge branch 'feat/chamfer' into feat/fillet
ffd4df2
@jonahrb
implement fillet and test
4406062
@dependabot @pyansys-ci-bot
build: bump ansys-tools-visualization-interface from 0.6.2 to 0.7.0 (#…
9ac5481 
…1619)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: pyansys-ci-bot <[email protected]>
@jonahrb
update from main
502a57e
@jonahrb
move to geometry commands
0933d3f
@jonahrb
cleanup old pull tools
449c8a9
@pyansys-ci-bot
chore: adding changelog file 1620.added.md [dependabot-skip]
ac6d50d
@jonahrb
Merge branch 'feat/fillet' of https://github.com/ansys/pyansys-geometry…
9a10bc2 
… into feat/fillet
@jonahrb
fix test
1cc7881
@jonahrb jonahrb requested a review from a team as a code owner January 10, 2025 19:27
@jonahrb jonahrb changed the title Feat/fillet feat: create a fillet on an edge/face Jan 10, 2025
@jonahrb jonahrb self-assigned this Jan 10, 2025
@github-actions github-actions bot added maintenance Package and maintenance related enhancement New features or code improvements labels Jan 10, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.35%. Comparing base (ed028b0) to head (a1716c8).

Additional details and impacted files 
@@           Coverage Diff           @@
##            blitz    #1621   +/-   ##
=======================================
  Coverage   91.34%   91.35%           
=======================================
  Files          87       87           
  Lines        7131     7139    +8     
=======================================
+ Hits         6514     6522    +8     
  Misses        617      617

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobrkerstetter jacobrkerstetter Awaiting requested review from jacobrkerstetter

@mlkaplan36 mlkaplan36 Awaiting requested review from mlkaplan36

At least 1 approving review is required to merge this pull request.

Assignees

@jonahrb jonahrb

Labels
enhancement New features or code improvements maintenance Package and maintenance related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonahrb @pyansys-ci-bot @RobPasMue