Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade hash32 and silence miri false positive #21

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

0xalpharush
Copy link

The current version of hash32 is about a year older than the one most recently released and has some behavior that is (incorrectly) flagged as undefined behavior (UB) by tools like Miri. This prevents any tool downstream of rbpf from using the rustc flags and tools like miri to identify UB as it will fail (xref rust-embedded-community/hash32#14).

$ RUSTFLAGS="-Zstrict-init-checks" cargo +nightly test
thread 'elf::test::test_entrypoint' panicked at core/src/panicking.rs:221:5:
attempted to leave type `murmur3::Buffer` uninitialized, which is invalid
thread caused non-unwinding panic. aborting.

Upgrading hash32 fixes this.

Migrating this PR here solana-labs#618

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant