[SPARK-50906][SS] Add nullability check for if inputs of to_avro align with schema #49590
+41
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanyue-xia
force-pushed
the
to_avro_improve_NPE
branch
from
3291312 to
6052ce8
Compare
MaxGekk
reviewed
Jan 22, 2025
connector/avro/src/test/scala/org/apache/spark/sql/avro/AvroCatalystDataConversionSuite.scala
Outdated
Show resolved
Hide resolved
sql/core/src/main/scala/org/apache/spark/sql/avro/AvroSerializer.scala
Outdated
Show resolved
Hide resolved
fanyue-xia
force-pushed
the
to_avro_improve_NPE
branch
from
6052ce8 to
93e8a4b
Compare
fanyue-xia
force-pushed
the
to_avro_improve_NPE
branch
5 times, most recently
from
01e48be to
d5ad9b1
Compare
fanyue-xia
force-pushed
the
to_avro_improve_NPE
branch
from
d5ad9b1 to
8fbda34
Compare
| row: InternalRow => | ||
| val result = new Record(avroStruct) | ||
| var i = 0 | ||
| while (i < numFields) { | ||
| if (row.isNullAt(i)) { | ||
| val avroField = avroFields.get(i) | ||
| if (!avroField.schema().isNullable) { |
There was a problem hiding this comment.
Shall we put this nullable info in an array outside the lambda? So that we can simply check
if isSchemaNullable(i)
| assert(ex.getCause.isInstanceOf[java.lang.NullPointerException]) | ||
| assert(ex.getCause.getMessage.contains( | ||
| "null value for (non-nullable) string at test_schema.Name")) | ||
| checkError( |
There was a problem hiding this comment.
Shall we also test null nested columns?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Previously, we don't explicitly check when input of
to_avroisnullbut the schema does not allownull. As a result, a NPE will be raised in this situation. This PR adds the check during serialization before writing to avro and raises user-facing error if above occurs.Why are the changes needed?
It makes it easier for the user to understand and face the error.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit test
Was this patch authored or co-authored using generative AI tooling?
No