[SPARK-50953][PYTHON][CONNECT] Add support for non-literal paths in VariantGet #49609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
reviewed
Jan 23, 2025
HyukjinKwon
approved these changes
Jan 23, 2025
chenhao-db
reviewed
Jan 23, 2025
...st/src/main/scala/org/apache/spark/sql/catalyst/expressions/variant/variantExpressions.scala
Outdated
Show resolved
Hide resolved
...st/src/main/scala/org/apache/spark/sql/catalyst/expressions/variant/variantExpressions.scala
Outdated
Show resolved
Hide resolved
...st/src/main/scala/org/apache/spark/sql/catalyst/expressions/variant/variantExpressions.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Jan 24, 2025
...st/src/main/scala/org/apache/spark/sql/catalyst/expressions/variant/variantExpressions.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR allows the
variant_getexpression to support non-literal path inputs.Why are the changes needed?
Currently,
variant_getonly supports literal paths as the second argument. Users may have columns containing paths which they would want to extract from variants. This PR allows this functionality.Does this PR introduce any user-facing change?
Yes, prior to this PR,
variant_getdid not have support for non-literal paths.How was this patch tested?
Unit tests to make sure that:
Was this patch authored or co-authored using generative AI tooling?
No.