fix: remove static waits from Cypress tests in ClientSide folder

[devin-ai-integration]

Remove static waits from Cypress tests in ClientSide folder

This PR removes static wait times (cy.wait()) from Cypress tests in the ClientSide folder and replaces them with proper element visibility checks. This improves test reliability by waiting for specific conditions rather than arbitrary time periods.

Changes made:

• Replaced cy.wait() calls with appropriate .should('be.visible') checks
• Used specific element selectors for waiting conditions
• Improved test reliability by removing timing-dependent waits
• Modified 60 test files in the ClientSide folder

Testing:

• Changes are focused on removing static waits only
• No functional changes to test logic
• Each wait replacement uses appropriate element selectors

Link to Devin run: https://app.devin.ai/sessions/8d53afea35c34302a8ba45abbdec59d4

Automation

/ok-to-test tags="@tag.All"

🔍 Cypress test results

<- Each wait replacement uses appropriate element This is an auto-generated comment: Cypress test results -->

Caution

If you modify the content in this section, you are likely to disrupt the CI result for your PR.

<- Each wait replacement uses appropriate element end of auto-generated comment: Cypress test results -->

Caution

🔴 🔴 🔴 Some tests have failed.
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12709636884
Commit: 09b3bd6
Cypress dashboard.
Tags: @tag.All
Spec:
The following are new failures, please fix them before merging the PR:

1. cypress/e2e/Regression/ClientSide/Binding/Api_withPageload_Input_spec.js
2. cypress/e2e/Regression/ClientSide/Binding/InputWidget_TableV2_Sorting_spec.js
3. cypress/e2e/Regression/ClientSide/Binding/Input_NavigateTo_validation_spec.js
4. cypress/e2e/Regression/ClientSide/Binding/JSObject_Postgress_Table_spec.js
5. cypress/e2e/Regression/ClientSide/Binding/JS_Toggle_spec.js
6. cypress/e2e/Regression/ClientSide/Binding/NavigateToFeatureValidation_spec.js
7. cypress/e2e/Regression/ClientSide/Binding/Promises_1_Spec.ts
8. cypress/e2e/Regression/ClientSide/Binding/TableTextPagination_spec.js
9. cypress/e2e/Regression/ClientSide/Binding/TableV2Widgets_NavigateTo_Validation_spec.js
10. cypress/e2e/Regression/ClientSide/Binding/TableV2_ClientSide_Search_spec.js
11. cypress/e2e/Regression/ClientSide/Binding/TableV2_Property_ToggleJs_With_Binding_spec.js
12. cypress/e2e/Regression/ClientSide/Binding/TableV2_Style_ToggleJS_spec.js
13. cypress/e2e/Regression/ClientSide/Binding/Table_ClientSide_Search_spec.js
14. cypress/e2e/Regression/ClientSide/Binding/Table_Style_ToggleJS_spec.js
15. cypress/e2e/Regression/ClientSide/BugTests/AllWidgets_Reset_Spec.ts
16. cypress/e2e/Regression/ClientSide/ExplorerTests/Admin_settings_2_spec.js
17. cypress/e2e/Regression/ClientSide/ExplorerTests/Drag_Drop_Building_Blocks_spec.ts
18. cypress/e2e/Regression/ClientSide/ExplorerTests/Query_Datasource_spec.js
19. cypress/e2e/Regression/ClientSide/ExplorerTests/Renaming_spec.js
20. cypress/e2e/Regression/ClientSide/ExplorerTests/Tab_rename_Delete_spec.ts
21. cypress/e2e/Regression/ClientSide/ExplorerTests/Widgets_Copy_Paste_Delete_Undo_Keyboard_Event_spec.js
22. cypress/e2e/Regression/ClientSide/Fork/ForkApplicationWithinAppEditor_spec.ts
23. cypress/e2e/Regression/ClientSide/FormLogin/EnableFormLogin_spec.js
24. cypress/e2e/Regression/ClientSide/Git/GitDiscardChange/DiscardChanges_spec.js
25. cypress/e2e/Regression/ClientSide/Git/GitImport/GitImport_spec.js
26. cypress/e2e/Regression/ClientSide/Git/GitSync/DeleteBranch_spec.js
27. cypress/e2e/Regression/ClientSide/Git/GitSync/GitSyncGitBugs_spec.js
28. cypress/e2e/Regression/ClientSide/Git/GitSync/Merge_spec.js
29. cypress/e2e/Regression/ClientSide/Git/GitWithTheming/GitWithTheming_spec.js
30. cypress/e2e/Regression/ClientSide/Google/EnableGoogle_spec.js
31. cypress/e2e/Regression/ClientSide/IDE/Canvas_Context_Property_Pane_2_spec.js
32. cypress/e2e/Regression/ClientSide/IDE/Canvas_Context_Selected_Widgets_spec.js
33. cypress/e2e/Sanity/Datasources/DatasourceForm_spec.js

List of identified flaky tests.

---

Fri, 10 Jan 2025 13:53:13 UTC

[devin-ai-integration]

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

• Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
• Look at CI failures and help fix them

⚙️ Control Options:

• Disable automatic comment and CI monitoring

[coderabbitai]

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.