[WIP] use new dune ctypes stanza #41
Conversation
ffi/dune
Outdated
| ; hack: repeated include dirs from root and relative since this gets | ||
| ; called from multiple places | ||
| (c_flags (-I../vendor/headers -Ivendor/headers)))) | ||
| (headers (preamble "#if defined(__MINGW32__) || defined(__MINGW64__) |
There was a problem hiding this comment.
This preamble might be better off in a separate file, and referenced from here. I can see it getting awkward fast to embed C headers in dune files.
There was a problem hiding this comment.
Oh, the dune stanza already supports that. I just pushed a version that does the include approach instead.
(I think it's still nice to provide an option to include a preamble in the dune feature as well)
|
This is a very pleasing amount of red indeed! The new stanzas are looking awesome... |
mbacarella
changed the title
|
marked as WIP. this depends on dune 3.0 to be released (and some additional meta file fixups) before it can be merged. |
|
I haven't reviewed in detail, but the overall approach in this PR looks very good to me. |
|
How ready is this PR ? It will be useful for dune monorepos as there are issues with the ctypes port currently. |
I'm not aware of any deficiencies, it's WIP because I don't want it accidentally merged with the pin-depends to a specific dune version in there. I'll freshen this PR up after dune 3.0 is released. |
| (vendored | ||
| ; hack: repeated include dirs from root and relative since this gets | ||
| ; called from multiple places | ||
| (c_flags (-I../vendor/headers -Ivendor/headers)))) |
There was a problem hiding this comment.
I think the only issue is here: this doesn't work in a dune workspace created with opam-monorepo.
This is already known but I'm linking the relevant issue : ocaml/dune#5325
There was a problem hiding this comment.
Ah. It may take me awhile to get around to updating dune-ctypes to fix this the clean way.
Thoughts on what a better hack than the current hack would be in the meantime? I assume this comes up fairly often in opam-monorepo?
That has now been released, so this PR could be finalized. |
|
Closing in favor of #67 |
Ports ocaml-yaml to use the anticipated dune ctypes feature
ocaml/dune#3905
Using this feature gets rid of the stub generator utilities and intermediate libraries. This PR also drops some deprecated/removed dune features.