-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump cdk-assets #33088
base: main
Are you sure you want to change the base?
chore: bump cdk-assets #33088
Conversation
This is necessary because it requires code changes in order to be compatible with the new version, which we need for the monorepo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter fails with the following errors:
❌ CLI code has changed. A maintainer must run the code through the testing pipeline (git fetch origin pull/33088/head && git push -f origin FETCH_HEAD:test-main-pipeline), then add the 'pr-linter/cli-integ-tested' label when the pipeline succeeds.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed, add Clarification Request
to a comment.
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #33088 +/- ##
==========================================
- Coverage 80.79% 80.78% -0.01%
==========================================
Files 232 232
Lines 14110 14111 +1
Branches 2453 2453
==========================================
Hits 11400 11400
- Misses 2430 2431 +1
Partials 280 280
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@@ -91,7 +91,7 @@ | |||
"@smithy/util-waiter": "3.1.6", | |||
"archiver": "^5.3.2", | |||
"camelcase": "^6.3.0", | |||
"cdk-assets": "3.0.0-rc.124", | |||
"cdk-assets": "^3.0.0-rc.127", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The caret has no effect with pre-release versions.
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This is necessary because it requires code changes in order to be compatible with the new version, which we need for the monorepo.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license