Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump cdk-assets #33088

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

chore: bump cdk-assets #33088

wants to merge 9 commits into from

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Jan 23, 2025

This is necessary because it requires code changes in order to be compatible with the new version, which we need for the monorepo.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

This is necessary because it requires code changes in order to be
compatible with the new version, which we need for the monorepo.
@rix0rrr rix0rrr requested a review from a team as a code owner January 23, 2025 08:45
@github-actions github-actions bot added the p2 label Jan 23, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team January 23, 2025 08:46
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 23, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter fails with the following errors:

❌ CLI code has changed. A maintainer must run the code through the testing pipeline (git fetch origin pull/33088/head && git push -f origin FETCH_HEAD:test-main-pipeline), then add the 'pr-linter/cli-integ-tested' label when the pipeline succeeds.

If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.78%. Comparing base (06144d9) to head (c19d704).
Report is 13 commits behind head on main.

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #33088      +/-   ##
==========================================
- Coverage   80.79%   80.78%   -0.01%     
==========================================
  Files         232      232              
  Lines       14110    14111       +1     
  Branches     2453     2453              
==========================================
  Hits        11400    11400              
- Misses       2430     2431       +1     
  Partials      280      280              
Flag Coverage Δ
suite.unit 80.78% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 79.51% <0.00%> (-0.02%) ⬇️
packages/aws-cdk-lib/core 82.17% <ø> (ø)

@rix0rrr rix0rrr added the pr-linter/exempt-codecov The PR linter will not require codecov checks to pass label Jan 24, 2025
@@ -91,7 +91,7 @@
"@smithy/util-waiter": "3.1.6",
"archiver": "^5.3.2",
"camelcase": "^6.3.0",
"cdk-assets": "3.0.0-rc.124",
"cdk-assets": "^3.0.0-rc.127",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The caret has no effect with pre-release versions.

@rix0rrr rix0rrr deployed to test-pipeline January 26, 2025 18:25 — with GitHub Actions Active
@aws-cdk-automation
Copy link
Collaborator

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: c19d704
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-codecov The PR linter will not require codecov checks to pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants